<html>
<head><meta charset="utf-8"><title>Housekeeping · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html">Housekeeping</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="188432156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188432156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Kirill Bulatov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188432156">(Feb 18 2020 at 08:37)</a>:</h4>
<p>Hey, triage team, can you please close two duplicates in favor of the more detailed tickets?<br>
I lack the permissions to do this myself.</p>
<p><a href="https://github.com/rust-analyzer/rust-analyzer/issues/1480" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/issues/1480">https://github.com/rust-analyzer/rust-analyzer/issues/1480</a> -&gt; <a href="https://github.com/rust-analyzer/rust-analyzer/issues/2733" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/issues/2733">https://github.com/rust-analyzer/rust-analyzer/issues/2733</a><br>
<a href="https://github.com/rust-analyzer/rust-analyzer/issues/2919" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/issues/2919">https://github.com/rust-analyzer/rust-analyzer/issues/2919</a> -&gt; <a href="https://github.com/rust-analyzer/rust-analyzer/issues/1062" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/issues/1062">https://github.com/rust-analyzer/rust-analyzer/issues/1062</a></p>
<p>Thanks.</p>



<a name="188432374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188432374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188432374">(Feb 18 2020 at 08:40)</a>:</h4>
<p>you are on the triage team now</p>



<a name="188432389"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188432389" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188432389">(Feb 18 2020 at 08:41)</a>:</h4>
<p>Oops</p>



<a name="188432400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188432400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Kirill Bulatov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188432400">(Feb 18 2020 at 08:41)</a>:</h4>
<p>Thank you both <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="188446042"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188446042" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Kirill Bulatov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188446042">(Feb 18 2020 at 12:24)</a>:</h4>
<p>More on the housekeeping:</p>
<ul>
<li>
<p>I see that we update crate dependencies from time to time, but do not touch <code>Cargo.toml</code> which results in something like this:<br>
<a href="/user_uploads/4715/jKXfgAWlIM515kFW82R3hJK_/pasted_image.png" target="_blank" title="pasted_image.png">pasted image</a> <br>
Should we update those? <br>
Maybe also remove the patch number since it means nothing without <code>=</code>?</p>
<div class="message_inline_image"><a href="/user_uploads/4715/jKXfgAWlIM515kFW82R3hJK_/pasted_image.png" target="_blank" title="pasted image"><img src="/user_uploads/4715/jKXfgAWlIM515kFW82R3hJK_/pasted_image.png"></a></div></li>
<li>
<p>Should we do something about <code>clippy</code> warnings in the project?<br>
Currently the amount of warnings we get now is significant (even considering that some of them are false-positive).</p>
</li>
</ul>



<a name="188446254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188446254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188446254">(Feb 18 2020 at 12:28)</a>:</h4>
<blockquote>
<p>Maybe also remove the patch number since it means nothing without =?</p>
</blockquote>
<p>It does set a lower bound</p>



<a name="188446264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188446264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188446264">(Feb 18 2020 at 12:29)</a>:</h4>
<p>I wouldn't worry about 1). I'll be ok with bumping minors in Cargo.tomls, but I don't think that'll really help with anything</p>



<a name="188446283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188446283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Kirill Bulatov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188446283">(Feb 18 2020 at 12:29)</a>:</h4>
<blockquote>
<p>It does set a lower bound</p>
</blockquote>
<p>Whis is out-of-date anyway and de facto enforced by the lockfiles.</p>



<a name="188446295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188446295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188446295">(Feb 18 2020 at 12:29)</a>:</h4>
<p>For 2), I am against enabling clippy on CI, but selectively fixing issues and silencing high fpr lints (we have <code>cargo xtask link</code> for that) seems fine</p>



<a name="188446549"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188446549" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188446549">(Feb 18 2020 at 12:33)</a>:</h4>
<p>It might be especiilay useful to <code>auto fix</code> the trivial into conversion lint</p>



<a name="188446598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188446598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188446598">(Feb 18 2020 at 12:34)</a>:</h4>
<p>We should have  a lot of those after the hir splitting</p>



<a name="188447466"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping/near/188447466" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Housekeeping.html#188447466">(Feb 18 2020 at 12:47)</a>:</h4>
<p>oh I missed that particular <code>xtask</code>. Awesome.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>